Link file for air, cont. after squash branch from main
#737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarus
reviewed
May 19, 2025
Closed
clarus
reviewed
May 23, 2025
clarus
reviewed
May 25, 2025
| instances for arrays of them(?) | ||
| Is there some way to avoid this, since this will cause much inconvenience when other | ||
| types are calling this? *) | ||
| Record t {T U : Set} `{Link T} `{Link U} : Set := { |
There was a problem hiding this comment.
Suggested change
| Record t {T U : Set} `{Link T} `{Link U} : Set := { | |
| Record t {T U : Set} : Set := { |
Actually I think we can avoid the Link parameters for the definition of the type and add it only when necessary, what simplifies our definitions later.
There was a problem hiding this comment.
Actually I think we can avoid the
Linkparameters for the definition of the type and add it only when necessary, what simplifies our definitions later.
As mentioned in the note above, the problem here is I cannot remove the link parameters, or otherwise there will be missing link instances to pass the compiler check. I was also wondering if we can have a better way to handle this...
There was a problem hiding this comment.
OK yes I have not seen that the references require this!
clarus
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #728 , #736 , for #731 .
of_valueforcolumnsblake3_air::air